Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve building native extensions #502

Merged
merged 42 commits into from Jul 14, 2023
Merged

Improve building native extensions #502

merged 42 commits into from Jul 14, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Jul 13, 2023

No description provided.

jwerle added 30 commits July 7, 2023 09:02
@jwerle
refactor(): wip
95a106c
@jwerle
refactor(): support external extension sources
7e3b81d
@jwerle
fix(include/socket/extension.h): fix 'sapi_process_spawn_kill' name
b2a0c45
@jwerle
refactor(src/extension/process.cc): guard ios/ fix 'sapi_process_spaw…
fc18af4 
…n_lkill' name
@jwerle
chore(.github/workflows/ci.yml): set 'VERBOSE=1' env var
9cc70d9
@jwerle
fix(src/cli/cli.cc): convert path to string
11a83dd
@jwerle
fix(bin/build-runtime-library.sh): include 'process/unix.cc' for android
7e6ee76
@jwerle
fix(src/cli/cli.cc): fix default 'CC' compiler
e979a85
@jwerle
chore(.gitignore): ignore '*.o' files
ba51b32
@jwerle
refactor(bin/cflags.sh): default visibility is hidden
9fcbcde
@jwerle
refactor(bin/install.sh): omit feature check in debug mode
3b42303
@jwerle
refactor(include/socket/extension.h): remove 'const' for scalar types
650eaf6
@jwerle
chore(src/desktop/main.cc): clean up
0a4a065
@jwerle
chore(src/extension/context.cc): remove 'const' for scalar types
6d35ec5
@jwerle
chore(src/extension/extension.cc): remove 'const' for scalar types
76b1250
@jwerle
refactor(src/extension/ipc.cc): 'nullptr' check, return 'false' on fa…
c4a4864 
…ilure
@jwerle
refactor(src/extension): remove 'const' for scalar types
796f95d
@jwerle
refactor(test/src/application.js): handle '#' comments
35c7fea
@jwerle
test(test/extension): use 'socket.ini' for extension
c704dac
@jwerle
refactor(src/cli): fix extension source for android
38b5890
@jwerle
fix(src/extension/ipc.cc): fix context data
f018d2f
@jwerle
feat(src/common.hh): support default value in 'getEnv'
5c653b1
@jwerle
refactor(bin/android-functions.sh): remove ABIs not worth supporting
837caf9
@jwerle
refactor(src/cli/templates.hh): remove useless src addition
8c319d4
@jwerle
fix(src/cli/cli.cc): improve building android extensions
624dfbc
@jwerle
fix(bin/cflags.sh): fix android errors for ndk path
35538f2
@jwerle
fix(api/ipc.js): fix promise methods in proxy, handle nested data in …
d3c4a6a 
…results
@jwerle
refactor(api/ipc.js): include 'id' in 'Result'
d6936c8
@jwerle
refactor(include/socket/extension.h): require 'message' for 'send_byt…
c836a89 
…es/send_json'
@jwerle
refactor(src/common.hh): mark 'init.cc' impls as extern/ fix '_WIN32'…
aeaa7d8 
… check
@jwerle jwerle added enhancement New feature or request cli extension An issue, task, or discussion related to native extensions labels Jul 13, 2023
@jwerle jwerle requested a review from chicoxyzzy July 13, 2023 14:47
@jwerle jwerle self-assigned this Jul 13, 2023
chicoxyzzy
chicoxyzzy reviewed Jul 13, 2023
View reviewed changes
api/ipc.js Show resolved Hide resolved
api/ipc.js Show resolved Hide resolved
api/ipc.js Show resolved Hide resolved
src/cli/cli.cc Show resolved Hide resolved
src/cli/cli.cc Outdated Show resolved Hide resolved
src/cli/cli.cc Outdated Show resolved Hide resolved
src/cli/cli.cc Show resolved Hide resolved
chicoxyzzy
chicoxyzzy reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux build is failing because resolvePromise call is not updated in the linux.cc

@jwerle jwerle requested a review from chicoxyzzy July 14, 2023 09:27
chicoxyzzy
chicoxyzzy approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwerle jwerle merged commit 3f85982 into master Jul 14, 2023
6 of 8 checks passed
@jwerle jwerle deleted the extension-configure-script branch July 14, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

Assignees

@jwerle jwerle

Labels
cli enhancement New feature or request extension An issue, task, or discussion related to native extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwerle @chicoxyzzy