Land extension fixes #518
Merged
Land extension fixes #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
requested review from
jwerle,
heapwolf and
chicoxyzzy
and removed request for
jwerle and
heapwolf
heapwolf
reviewed
Aug 8, 2023
heapwolf
reviewed
Aug 8, 2023
heapwolf
approved these changes
Aug 8, 2023
chicoxyzzy
approved these changes
Aug 9, 2023
| @@ -3609,7 +3609,7 @@ declare module "socket:dgram" { | |||
| */ | |||
| export class Socket extends EventEmitter { | |||
| constructor(options: any, callback: any); | |||
| id: bigint; | |||
| id: any; | |||
There was a problem hiding this comment.
hmm is this loose typing because of this.id = options?.id || rand64()?
can we type options bag?
| @@ -176,7 +176,7 @@ constexpr auto gPListInfo = R"XML(<?xml version="1.0" encoding="UTF-8"?> | |||
| <key>DTSDKBuild</key> | |||
| <string>10.13</string> | |||
| <key>CFBundleVersion</key> | |||
| <string>v{{meta_version}}</string> | |||
| <string>{{meta_version}}</string> | |||
|
|
|
I think we can merge this |
I'll double check with @jwerle today about it (its his commits). |
bcomnes
force-pushed
the
improve-extension-context-tree-and-builds
branch
from
6b5de3a
to
792889a
Compare
|
Tests are failing for existing reasons. Landing this now. |
jwerle
added a commit
that referenced
this pull request
Aug 22, 2023
* refactor(src/extension): improve init state and context tree * refactor(src/cli): allow building jsut an extension * refactor(src): clean up / tidy * refactor(include/socket/extension.h): include 'sapi_context_alloc' prototype * refactor(api): clean up, listen 'connect'() for dgram * fix(extension): remove from 'init' list after deinit * refactor(src/extension/extension.cc: use 'std::make_shared' * fix(src/cli/templates.hh): remove 'v' prefix in 'CFBundleVersion' * chore(api/index.d.ts): generate typings * Fix spacing --------- Co-authored-by: Joseph Werle <joseph.werle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwerle Looks like these are needed in the latest extension work.