fix(desktop/main.cc): check for invalid values for the application window sizes #523

chicoxyzzy · 2023-08-09T15:33:32Z

…ndow sizes

chicoxyzzy · 2023-08-09T15:35:40Z

src/desktop/main.cc

+        stdWrite("Invalid value for " + property + ": " + value, true);
+        app.appData[property] = setDefaultValue(property);
+        stdWrite("Setting default value: " + app.appData[property], true);


these stdWrites don't work

chicoxyzzy · 2023-08-10T05:41:55Z

other than #523 (comment) this is fixed here

chicoxyzzy requested review from heapwolf and jwerle August 9, 2023 15:33

chicoxyzzy force-pushed the window_sizes branch from b7c137f to 1111a87 Compare August 9, 2023 15:34

fix(desktop/main.cc): check for invalid values for the application wi…

f0a3be3

…ndow sizes

chicoxyzzy force-pushed the window_sizes branch from 1111a87 to f0a3be3 Compare August 9, 2023 16:54

chicoxyzzy commented Aug 10, 2023

View reviewed changes

jwerle approved these changes Aug 10, 2023

View reviewed changes

chicoxyzzy merged commit f0ada03 into master Aug 14, 2023
4 of 8 checks passed

chicoxyzzy deleted the window_sizes branch August 14, 2023 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(desktop/main.cc): check for invalid values for the application window sizes #523

fix(desktop/main.cc): check for invalid values for the application window sizes #523

chicoxyzzy commented Aug 9, 2023

chicoxyzzy Aug 9, 2023

chicoxyzzy commented Aug 10, 2023 •

edited

fix(desktop/main.cc): check for invalid values for the application window sizes #523

fix(desktop/main.cc): check for invalid values for the application window sizes #523

Conversation

chicoxyzzy commented Aug 9, 2023

chicoxyzzy Aug 9, 2023

Choose a reason for hiding this comment

chicoxyzzy commented Aug 10, 2023 • edited

chicoxyzzy commented Aug 10, 2023 •

edited