Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle various common mime types on Windows #588

Merged
merged 1 commit into from Sep 14, 2023
Merged

Handle various common mime types on Windows #588

merged 1 commit into from Sep 14, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Sep 14, 2023

Sometimes, a mime type cannot be determined from common extensions

@jwerle jwerle added bug Something isn't working windows labels Sep 14, 2023
@jwerle jwerle self-assigned this Sep 14, 2023
chicoxyzzy
chicoxyzzy approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list could become too big very soon. We can add webp, svg and maybe few other extensions

@jwerle
Copy link
Member Author

jwerle commented Sep 14, 2023

The list could become too big very soon. We can add webp, svg and maybe few other extensions

yep see https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
😂

@jwerle jwerle merged commit 6bb9296 into master Sep 14, 2023
4 of 8 checks passed
@jwerle jwerle deleted the handle-various-mimes-for-windows branch September 14, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@getify getify Awaiting requested review from getify

Assignees

@jwerle jwerle

Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwerle @chicoxyzzy