Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): run user build script after package is scaffolded #642

Merged

Conversation

aleclarson
Copy link
Contributor

In my case, this is useful for manipulating the Info.plist file from my build script.

In my case, this is useful for manipulating the Info.plist file
@jwerle
Copy link
Member

jwerle commented Oct 4, 2023

@aleclarson perhaps we can introduce a new life cycle here instead of moving the build phase script/copy around

Also, you could configure additions to the Info.plist with:

[mac.info.plist]
file = "file/to/mixin.plist"
# or
data = "data/to/mixin/into/Info.plist"

same for iOS:

[ios.info.plist]
file = "file/to/mixin.plist"
# or
data = "data/to/mixin/into/Info.plist"

we have not documented these features of the socket.ini yet

@aleclarson
Copy link
Contributor Author

perhaps we can introduce a new life cycle here

what is the use case for running build script before scaffolding? nothing the build script could do would affect the scaffolding, so it's better to run it after so it can alter any of the project files before xcodebuild et al are applied

Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that build before scaffolding makes no sense.

LGTM

@jwerle jwerle merged commit 3510f07 into socketsupply:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants