fix(types): fixes to @socketsupply/socket types #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
approved these changes
Oct 5, 2023
|
@aleclarson please run |
aleclarson
force-pushed
the
fix/typings-1
branch
from
3375800
to
914bd8d
Compare
aleclarson
commented
Oct 5, 2023
|
|
||
| // type could be [(string|number)=] | ||
| const parenthasisedType = rawType | ||
| .replace(/\s*\|\s*/g, ' \\| ') | ||
| .replace(/\[|\]/g, '') | ||
| // now it is (string|number)= | ||
| const optional = parenthasisedType.endsWith('=') | ||
| const optional = parenthasisedType.endsWith('=') || /^ *\[/.test(rawName) |
There was a problem hiding this comment.
added handling for [optionalParam] without default value
aleclarson
commented
Oct 5, 2023
| @@ -141,21 +141,21 @@ export function generateApiModuleDoc ({ | |||
| item.signature = item.signature || [] | |||
| const parts = attr.split(/-\s+(.*)/) | |||
| const { 1: rawType, 2: rawName } = parts[0].match(/{([^}]+)}(.*)/) | |||
| const [name, defaultValue] = rawName.replace(/[[\]']+/g, '').trim().split('=') | |||
| const [name, defaultValue] = rawName.replace(/[[\]']+/g, '').trim().split(/ *[=] */) | |||
There was a problem hiding this comment.
added whitespace tolerance to param name = splitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some broken types and made
Extensiongeneric so I could specify itsbindingtype