Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use pnpm workspaces #662

Merged
merged 1 commit into from Oct 6, 2023
Merged

chore: use pnpm workspaces #662

merged 1 commit into from Oct 6, 2023

Conversation

aleclarson
Copy link
Contributor

@aleclarson aleclarson commented Oct 6, 2023 •
edited

  • Users can decide for themselves between npm or pnpm
  • Disabled lockfile generation

Benefits of this PR

  • pnpm users don't have to set up the pnpm-workspace.yaml file themselves (which tells pnpm to install @socketsupply/socket-node dependencies when pnpm install is used in the root directory)
  • pnpm has a changesets guide with a Github CI action that automatically releases. Adding changesets in the future will also let you more easily align the package versions of @socketsupply/socket and @socketsupply/socket-node (see Fixed Packages in their docs)

@jwerle jwerle added the npm An issue, task, discussion, or pull request related to the NPM modules label Oct 6, 2023
@jwerle jwerle merged commit 8d1cec7 into socketsupply:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

Assignees

@aleclarson aleclarson

Labels
npm An issue, task, discussion, or pull request related to the NPM modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aleclarson @jwerle