feat(extension): add sapi_ipc_send_chunk and sapi_ipc_send_event
#679
Conversation
- Before calling sapi_ipc_send_chunk, you must set the Transfer-Encoding header to `chunked` and then call sapi_ipc_reply. - When using sapi_ipc_send_chunk, the frontend should use XMLHttpRequest. Currently, the Fetch API does not support response streaming in WebKit. - Before calling sapi_ipc_send_event, you must set the Content-Type header to `text/event-stream` and then call sapi_ipc_reply. - When using sapi_ipc_send_event, the frontend should use EventSource.
There was a problem hiding this comment.
Left some comments. We'll need to set isHTTP = true in src/window/win.cc too. I wonder if we need a more general way to say where the source of the IPC::Message is from cc @chicoxyzzy
| @@ -1096,6 +1096,51 @@ extern "C" { | |||
| const sapi_json_any_t* json | |||
| ); | |||
|
|
|||
| /** | |||
| * Write a chunk to the HTTP response associated with the IPC result. | |||
There was a problem hiding this comment.
Can we include a note about this working on iOS/macOS only?
There was a problem hiding this comment.
or warning if platform is not iOS/macOS, but I'm not sure if that check is available here
|
👍 |
| @@ -1096,6 +1096,51 @@ extern "C" { | |||
| const sapi_json_any_t* json | |||
| ); | |||
|
|
|||
| /** | |||
| * Write a chunk to the HTTP response associated with the IPC result. | |||
There was a problem hiding this comment.
or warning if platform is not iOS/macOS, but I'm not sure if that check is available here
| message.buffer.bytes, | ||
| message.buffer.size | ||
| ); | ||
| auto msg = SSC::IPC::Message(message); |
There was a problem hiding this comment.
We wanted an AOT decode so the sapi_ipc_message_get() calls get a decoded value
There was a problem hiding this comment.
I've guaranteed that Router::invoke receives an IPC::Message with decoded values in other parts of this PR, which means the values will be decoded by the time the commented line is reached.
When Router::invoke is called with a uri string, values are always decoded (is this a problem?). When Router::invoke is called with a IPC::Message instead, it's assumed that the message has decoded values, which I've checked is true anywhere this overload is used as of now.
| if (strcasecmp(name, "content-type") == 0 && | ||
| strcasecmp(value, "text/event-stream") == 0) { | ||
| result->post = SSC::Post(); | ||
| result->post.event_stream = | ||
| std::make_shared<std::function<bool(const char*, const char*, bool)>>( | ||
| [result](const char* name, const char* data, bool finished) { | ||
| return false; | ||
| }); | ||
| } else if (strcasecmp(name, "transfer-encoding") == 0 && | ||
| strcasecmp(value, "chunked") == 0) { | ||
| result->post = SSC::Post(); | ||
| result->post.chunk_stream = | ||
| std::make_shared<std::function<bool(const char*, size_t, bool)>>( | ||
| [result](const char* chunk, size_t chunk_size, bool finished) { | ||
| return false; | ||
| }); | ||
| } |
There was a problem hiding this comment.
We could probably move this to sapi_ipc_reply later as a perf optimization.
chunkedand then call sapi_ipc_reply.text/event-streamand then call sapi_ipc_reply.