Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src/cli/cli.cc): fix arguments parsing #697

Merged
merged 3 commits into from Oct 16, 2023
Merged

fix(src/cli/cli.cc): fix arguments parsing #697

merged 3 commits into from Oct 16, 2023

Conversation

chicoxyzzy
Copy link
Member

Fixes #695

Also:

  • fixes weird cases when path is recognized as an option value
  • adds an error when value is provided for option which doesn't requre value
  • fixes debug and verbose options propagation

@chicoxyzzy chicoxyzzy merged commit 224dff5 into master Oct 16, 2023
4 of 8 checks passed
@chicoxyzzy chicoxyzzy deleted the cli_fixes branch October 16, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

@bcomnes bcomnes Awaiting requested review from bcomnes

Assignees

@chicoxyzzy chicoxyzzy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssc build -r <path> is looking for a config in cwd instead of the specified path
2 participants
@chicoxyzzy @jwerle