Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src/ipc/bridge.cc): add missing ios branch for base path in router resolution #724

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(src/ipc/bridge.cc): add missing ios branch for base path in router resolution #724

merged 1 commit into from
Oct 26, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Oct 26, 2023 •
edited

Fixes #718

@jwerle jwerle added bug Something isn't working ios An issue, task, or pull request related to iOS runtime An issue, task, or discussion related to the runtime core labels Oct 26, 2023
@jwerle jwerle self-assigned this Oct 26, 2023
chicoxyzzy
chicoxyzzy approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works on my laptop

@jwerle jwerle merged commit df32609 into master Oct 26, 2023
3 of 8 checks passed
@jwerle jwerle deleted the readd-ios-base-path-in-router branch October 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@jwerle jwerle

Labels
bug Something isn't working ios An issue, task, or pull request related to iOS runtime An issue, task, or discussion related to the runtime core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build for iOS Simulator on x86_64
2 participants
@jwerle @chicoxyzzy