Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce '[build] script.forward_arguments' #747

Merged
merged 7 commits into from
Nov 4, 2023

Conversation

chicoxyzzy
Copy link
Member

This is the simplest solution which fixes the #716. It doesn't pass any arguments as environment variables and just skips them until [build] pass.build.arguments is equal true explicitely

@chicoxyzzy chicoxyzzy added cli config An issue, discussion, or pull request related to application config labels Nov 3, 2023
@chicoxyzzy chicoxyzzy self-assigned this Nov 3, 2023
@chicoxyzzy chicoxyzzy linked an issue Nov 3, 2023 that may be closed by this pull request
api/CONFIG.md Outdated Show resolved Hide resolved
src/cli/cli.cc Outdated Show resolved Hide resolved
@jwerle jwerle changed the title [build] pass.build.arguments Introduce '[build] build.forward_arguments' Nov 3, 2023
@chicoxyzzy chicoxyzzy merged commit 0842a5a into master Nov 4, 2023
2 of 8 checks passed
@chicoxyzzy chicoxyzzy deleted the optionally_pass_build_args branch November 4, 2023 02:55
@jwerle jwerle changed the title Introduce '[build] build.forward_arguments' Introduce '[build] script.forward_arguments' Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli config An issue, discussion, or pull request related to application config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make passing arguments to a build script an opt-in behavior
2 participants