Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api/path): introduce well known path constants #761

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(api/path): introduce well known path constants #761

merged 1 commit into from
Nov 8, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Nov 8, 2023

This PR introduces well known path constants for use with path resolution or the socket:fs module.

It includes constants for the following:

  • path.DOWNLOADS A path to the user's or app container Downloads/ folder
  • path.DOCUMENTS A path to the user's or app container Documents/ folder
  • path.PICTURES A path to the user's or app container Pictures/ folder
  • path.DESKTOP A path to the user's or app container Desktop/ folder
  • path.VIDEOS A path to the user's or app container Videos/ folder
  • path.MUSIC A path to the user's or app container Music folder

@jwerle jwerle added enhancement New feature or request javascript An issue, discussion, or task related to the runtime javascript api An issue, task, or discussion related to public runtime APIs runtime An issue, task, or discussion related to the runtime core labels Nov 8, 2023
@jwerle jwerle self-assigned this Nov 8, 2023
chicoxyzzy
chicoxyzzy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today I learned what XDG stands for :)

@jwerle jwerle merged commit 5ef69b3 into master Nov 8, 2023
3 of 8 checks passed
@jwerle jwerle deleted the well-known-paths branch November 8, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@jwerle jwerle

Labels
api An issue, task, or discussion related to public runtime APIs enhancement New feature or request javascript An issue, discussion, or task related to the runtime javascript runtime An issue, task, or discussion related to the runtime core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwerle @chicoxyzzy