Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): make '[android] icon' optional #855

Merged
merged 1 commit into from Dec 18, 2023
Merged

refactor(cli): make '[android] icon' optional #855

merged 1 commit into from Dec 18, 2023

Conversation

jwerle
Copy link
Member

@jwerle jwerle commented Dec 18, 2023

Fixes #836

@jwerle jwerle added bug Something isn't working android cli labels Dec 18, 2023
@jwerle jwerle self-assigned this Dec 18, 2023
chicoxyzzy
chicoxyzzy approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwerle jwerle merged commit f477889 into master Dec 18, 2023
4 of 5 checks passed
@jwerle jwerle deleted the make-android-icon-optional branch December 18, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

Assignees

@jwerle jwerle

Labels
android bug Something isn't working cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make [android] icon config option optional
2 participants
@jwerle @chicoxyzzy