Use the auth property of the parsed URL

[lpinca]

There is no need to set the auth property in the parsed URL, becuase the url-parse module parses it correctly.

[brycekahle]

Great. Thanks for adding the tests too.

[3rd-Eden]

The code can be simplified even further. If the parsedUrl.set('path', replaceshizzle) is used instead of the replace logic you can just use parsedUrl.href for this.url as all that logic is also done in the url-parse module

[brycekahle]

Cool. I'll try and work that in. Thanks @3rd-Eden

[lpinca]

@3rd-Eden doesn't that also include the hash which is stripped away right now? I guess the same parsedUrl.set('hash', ''); can be used against that.

[3rd-Eden]

It doesnt need stripping as its already throwing an error when a hash is included a few lines above this.

Arnout Kazemier

On May 5, 2015, at 9:49 PM, Luigi Pinca notifications@github.com wrote:

@3rd-Eden doesn't that also include the hash which is stripped away right now? I guess the same parsedUrl.set('hash', ''); can be used against that.

—
Reply to this email directly or view it on GitHub.

[lpinca]

You are right, I've missed that.