Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection close when Transport timeout #358

Merged
merged 1 commit into from
Apr 30, 2017
Merged

Conversation

datso
Copy link
Contributor

@datso datso commented Feb 6, 2017

Here is my workaround for problem #334 .
Without closing the connection, "eventsource" transport will send request's to server even after "onclose" callback.

@brycekahle
Copy link
Contributor

It does not make sense to call close when the open event has not been emitted (the timeout). Let's continue the discussion in the issue.

@brycekahle brycekahle closed this Apr 30, 2017
@brycekahle
Copy link
Contributor

I apologize. I believe I understand the situation now. This does seem correct. I am slightly worried that transports may emit close events in this flow and cause a double call of _transportClose. I will try to investigate that, but this seems correct.

@brycekahle brycekahle reopened this Apr 30, 2017
@brycekahle brycekahle merged commit 9e1b0f6 into sockjs:master Apr 30, 2017
@brycekahle
Copy link
Contributor

@lpinca I'll try and do that this evening (UTC-4).

@lpinca
Copy link
Contributor

lpinca commented May 29, 2018

Thank you.

@brycekahle
Copy link
Contributor

1.1.5 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants