Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash with react-native@0.45.1 on Android #386

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Fixed crash with react-native@0.45.1 on Android #386

merged 1 commit into from
Jun 21, 2017

Conversation

iyegoroff
Copy link
Contributor

@iyegoroff iyegoroff commented Jun 21, 2017

It looks like because of some strict type checks on Java side code:
this.xhr.withCredentials = 'true';
leads to error:
TypeError: expected dynamic type 'boolean', but had type 'string'.

When I changed 'true' to true the error has gone.

@brycekahle
Copy link
Contributor

Thanks!

@brycekahle brycekahle merged commit a1028ed into sockjs:master Jun 21, 2017
@Dofff
Copy link

Dofff commented Jun 22, 2017

@iyegoroff i'that fixed.... but same issue.. what`s the problem?

@asgvard
Copy link

asgvard commented Aug 11, 2017

Probably because it's fixed in source folder, but not in dist minified version.
@brycekahle could we expect new build and npm version soon? It's quite important fix for RN users. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants