fixes for disonnect and decode #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Nov 9, 2022
auvipy
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix for extremely rare json decode issue
fix: prevent breaking next transport timeout if previous transport fa…
this PR contains 2 bugfixes we implemented in our sockjs fork. they never got merged as previous owner declined them since he couldn't reproduce the issue.
Decode issue occurs in rare occasions with spring boot sockjs integration. Sometimes sockjs was not able to parse message correctly.
Second issue is little bit easier to reproduce. If we set transports to
[ 'eventsource', 'iframe', 'htmlfile', 'xhr-streaming',]and them block with ublock eventsource, xhr, xhr_streaming them xhr when failing does not clear its timeout and when next transport kicks in then it's after ~ 20ms being cleared by previous transport timeout. This clears the timeout if the transport failed before its timeout kicked in. Currently if transport fails before its timeout then the next transport is being initialised with new timeout but the old timeout is still in a queue.
Take it or drop it.