Don't assume res._header exists
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`res._header` is an internal implementation detail. Hence, some implementations of the http server do not set this. [node-spdy](https://github.com/indutny/node-spdy) is an example.
SpaceK33z
changed the title
res._header existres._header exists
brycekahle
reviewed
Sep 19, 2016
| @@ -120,7 +120,7 @@ exports.GenericApp = class GenericApp | |||
| log_request: (req, res, data) -> | |||
| td = (new Date()) - req.start_date | |||
| @log('info', req.method + ' ' + req.url + ' ' + td + 'ms ' + | |||
| (if res.finished then res._header.split('\r')[0].split(' ')[1] \ | |||
| (if res.finished and res._header then res._header.split('\r')[0].split(' ')[1] \ | |||
There was a problem hiding this comment.
This will log (unfinished) if res._header does not exist, even if res.finished is true. Can you fix that?
brycekahle
requested changes
Sep 19, 2016
|
@brycekahle, it seems like the internal |
brycekahle
approved these changes
Sep 19, 2016
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res._headeris an internal implementation detail. Hence, some implementations of the http server do not set this. You can't blame them for this, because this is a hack.node-spdy is an example.