Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate hooks shown just because they contain the same word #47

Open
StephaneCapponi opened this issue Nov 27, 2023 · 0 comments
Open

Duplicate hooks shown just because they contain the same word #47

StephaneCapponi opened this issue Nov 27, 2023 · 0 comments
Assignees
@StephaneCapponi
Labels
bug Something isn't working
Milestone
0.3

Comments

@StephaneCapponi
Copy link
Collaborator

If there is two different hook that contain the same word, even if they are different throw an error:

socon.core.exceptions.ImproperlyConfigured: 'foo' already exists. Duplicates:
...

Issue is here:

socon/socon/core/manager.py

Line 319 in c808a32

if any(hook_name in n for n in configs.get(config.label, [])):

Instead of "hook_name in n" it should be "hook_name == n"
@StephaneCapponi StephaneCapponi added the bug Something isn't working label Nov 27, 2023
@StephaneCapponi StephaneCapponi added this to the 0.3 milestone Nov 27, 2023
@StephaneCapponi StephaneCapponi self-assigned this Nov 27, 2023
StephaneCapponi added a commit to StephaneCapponi/socon that referenced this issue Jun 24, 2024
@StephaneCapponi
[socon-dev#47] Fix duplicate hooks exception when they have similar n…
391e9c5 
…ames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephaneCapponi StephaneCapponi

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3
Development

When branches are created from issues, their pull requests are automatically linked.

47-duplicate-hooks-shown-just-because-they-contain-the-same-word StephaneCapponi/socon
1 participant
@StephaneCapponi