Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN-12742 Add capability to disable a secondary instance from reading … #199

Merged

Conversation

chitang
Copy link
Contributor

@chitang chitang commented Dec 31, 2016

…a dataset

update dataset_internal_name_map set disabled to now()

@socrata-jenkins
Copy link
Collaborator

This build looks good.

@chitang chitang force-pushed the chi/EN-12742/allow-disabling-secondary-instance-read branch from 53a77e0 to e75a8b6 Compare December 31, 2016 19:19
@socrata-jenkins
Copy link
Collaborator

This build looks good.

Copy link
Contributor

@rjmac rjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd tend to prefer _ != null to Option(_).isDefined, but it works either way!

@chitang chitang force-pushed the chi/EN-12742/allow-disabling-secondary-instance-read branch from e75a8b6 to e1e1494 Compare January 3, 2017 17:23
@socrata-jenkins
Copy link
Collaborator

Build failed.

…a dataset

update dataset_internal_name_map set disabled to now()

rebuild
@chitang chitang force-pushed the chi/EN-12742/allow-disabling-secondary-instance-read branch from e1e1494 to b38590a Compare January 3, 2017 17:31
@socrata-jenkins
Copy link
Collaborator

This build looks good.

@chitang chitang merged commit 18715c4 into master Jan 3, 2017
@chitang chitang deleted the chi/EN-12742/allow-disabling-secondary-instance-read branch January 3, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants