Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various feedback from @allejo #21

Open
5 tasks
chrismetcalf opened this issue Sep 21, 2016 · 0 comments
Open
5 tasks

Various feedback from @allejo #21

chrismetcalf opened this issue Sep 21, 2016 · 0 comments
Assignees

Comments

@chrismetcalf
Copy link
Contributor

  • composer.json should probably be updated with the new PHP requirement
  • unless you're mixing PHP with another language, the closing "?>" at the end of the file isn't necessary.
  • do you intend to expose Socrata::create_query_url and Socrata::create_curl_handle publically? if not, they can be private or protected
  • regarding phpunit, you're relying on whatever's installed on the tester's computer which may not be the same version you're using
  • When would the constructor return false? https://github.com/socrata/soda-php/blob/master/public/socrata.php#L24 if something isn't configured correctly in the constructor then an exception should be thrown instead
@chrismetcalf chrismetcalf self-assigned this Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant