added ansible installer for multicloud #1359

devanshjain7 · 2022-11-21T12:01:19Z

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
Added ansible installer for multicloud

Which issue(s) this PR fixes:

Fixes #1357

Testing
Independent multicloud installation using ansible has been tested on the following configuration:

Ubuntu version 20.04
Go version 1.17.9
Ansible version 2.9.6
Docker version 20.10.21
Docker Compose version 1.23.1

Ansible Installation succesfully completed:

All multi-cloud services up and running:

codecov · 2022-11-24T07:28:46Z

Codecov Report

Merging #1359 (941ffbb) into master (de94184) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59

PravinRanjan10 · 2022-11-24T07:23:10Z

installer/ansible/group_vars/common.yml

+ansible_os_family: Debian
+
+# Install as systemd process or standalone application: true / false
+# true: Will install api, dock, controller and etcd processes as a systemd services and enable them. Recommended for production use


remove api, dock, controller

PravinRanjan10 · 2022-11-24T07:24:41Z

installer/ansible/roles/cleaner/scenarios/backend.yml

@@ -0,0 +1,13 @@
+# Copyright 2018 The OpenSDS Authors.


why this file required?

thanks for pointing out. its not required. deleted.

PravinRanjan10 · 2022-11-24T07:30:26Z

installer/ansible/script/virtualenv3_exec.j2

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash


this file may not required. Please check

deleted this file

PravinRanjan10 · 2022-11-24T07:30:52Z

installer/ansible/script/virtualenv_exec.j2

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash


this file may not required. Please check

deleted this file

PravinRanjan10 · 2022-11-24T07:34:42Z

installer/ansible/group_vars/common.yml

+# delete database
+database_purge: true
+
+# OpenSDS configuration file


this line may not required. plz check

It is being used to remove etcd data directory while cleaning.
https://github.com/sodafoundation/multi-cloud/blob/b6459548812ed643e9a0e8f1186f5d341e86cab2/installer/ansible/roles/cleaner/handlers/main.yml#L39-L47

PravinRanjan10 · 2022-11-24T09:42:25Z

installer/ansible/script/set_nginx_config.sh

@@ -0,0 +1,43 @@
+#!/usr/bin/env bash


this file may not require. Please check

used by dashboard-installer
https://github.com/sodafoundation/multi-cloud/blob/b6459548812ed643e9a0e8f1186f5d341e86cab2/installer/ansible/roles/dashboard-installer/scenarios/source-code.yml#L41-L43

PravinRanjan10 · 2022-11-24T09:43:09Z

installer/ansible/script/sdsrc

+# Multi-Cloud service name in keystone
+MULTICLOUD_SERVER_NAME=${MULTICLOUD_SERVER_NAME:-opensds}
+
+# devstack keystone configuration


line 36-45 not required. Please check

also line # 24-25, 30-31.

removed unused variables. most of them are being used in keystone.sh

https://github.com/sodafoundation/multi-cloud/blob/b6459548812ed643e9a0e8f1186f5d341e86cab2/installer/ansible/script/keystone.sh

PravinRanjan10 · 2022-11-25T05:15:13Z

installer/ansible/clean.yml

@@ -0,0 +1,46 @@
+# Copyright 2019 The OpenSDS Authors.


joseph-v · 2022-11-25T06:35:00Z

installer/ansible/group_vars/dashboard.yml

@@ -0,0 +1,55 @@
+# Copyright 2019 The OpenSDS Authors.


This file may not be needed, when dashboard installation is removed

joseph-v · 2022-11-25T06:38:16Z

installer/ansible/install_dependencies.sh

+sudo add-apt-repository universe
+
+echo Enabling docker repository
+curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -


Check docker & ansible install step from Delfin. "add-apt-repository" is getting depricated

yes thanks. done

joseph-v · 2022-11-25T06:38:55Z

installer/ansible/install_dependencies.sh

+fi
+
+# Install docker compose
+echo Installing docker-compose


No need to install docker-compose, we can use docker compose from the new install steps for docker

currently supporting docker-compose instead of docker compose. @PravinRanjan10 pls let me know if any changes required here.

okay. Please go ahead with docker compose (the new install steps)

installer/ansible/roles/auth-installer/tasks/main.yml

joseph-v · 2022-11-25T06:41:06Z

installer/ansible/roles/cleaner/scenarios/auth-keystone.yml

+# limitations under the License.
+
+---
+- name: uninstall opensds keystone with the script


keystone required for mullti-cloud. even for API(postman)

joseph-v · 2022-11-25T06:41:19Z

installer/ansible/roles/cleaner/tasks/main.yml

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- name: stop container where dashboard is located


joseph-v · 2022-11-25T06:41:55Z

installer/ansible/roles/cleaner/tasks/main.yml

+# limitations under the License.
+
+- name: stop container where dashboard is located
+  docker_container:


Remove all dashboard, keystone cleanup

PravinRanjan10 · 2022-11-28T06:01:24Z

installer/README.md

@@ -0,0 +1,36 @@
+# Multicloud Installation Guide


update multi-cloud at every place

PravinRanjan10 · 2022-11-28T06:01:37Z

installer/README.md

+
+## Ansible Installer
+* Supported OS: **Ubuntu 18.04, 20.04**
+* Prerequisite: **Python 3.6 or above** should be installed


update go version, 1.17.9

PravinRanjan10 · 2022-11-28T06:18:57Z

installer/install_dependencies.sh

+apt-get install -y python3-pip
+
+# Install ansible if not present
+if [ "`which ansible`" != ""  ]; then


check for go1.17

…EADME

PravinRanjan10

LGTM

joseph-v

LGTM

anvithks · 2022-11-29T04:08:17Z

installer/install_dependencies.sh

+    if (( ${v[0]} == 1 && ${v[1]} >= 17 )); then
+        echo Go 1.17+ already installed, skipping.
+    else
+        echo Removing existing Go installation


@devanshjain7 @PravinRanjan10 User may have existing Go installation for some other work.
Before deleting the existing Go installation confirm with the user if it is ok.
Or we need to install the required Go version separately and use it.

added ansible installer for multicloud

d3bc749

PravinRanjan10 requested a review from rajat-soda November 24, 2022 05:28

updated os in ci.yml to ubuntu 20.04

9fa994f

PravinRanjan10 requested changes Nov 24, 2022

View reviewed changes

PravinRanjan10 reviewed Nov 24, 2022

View reviewed changes

PravinRanjan10 requested changes Nov 24, 2022

View reviewed changes

deleted files that are not required for multicloud installation

e53a0b3

PravinRanjan10 reviewed Nov 25, 2022

View reviewed changes

PravinRanjan10 requested a review from skdwriting November 25, 2022 05:55

joseph-v reviewed Nov 25, 2022

View reviewed changes

devanshjain7 added 5 commits November 25, 2022 15:36

Removed dashboard, updated install_dependencies.sh

e3cdfd6

updated the copyright header from OPENSDS to SODA

4e723f8

updated hardcoded host_ip in common.yml to env variable

43f6c45

Created README.md

2df19d3

upgraded docker-compose to docker compose

0b87597

PravinRanjan10 requested a review from sushanthakumar November 28, 2022 05:57

PravinRanjan10 requested changes Nov 28, 2022

View reviewed changes

PravinRanjan10 reviewed Nov 28, 2022

View reviewed changes

sushanthakumar approved these changes Nov 28, 2022

View reviewed changes

added go version check in install_dependencies.sh, minor changes in R…

c5ceadc

…EADME

PravinRanjan10 approved these changes Nov 28, 2022

View reviewed changes

removed etcd related file

941ffbb

joseph-v approved these changes Nov 28, 2022

View reviewed changes

PravinRanjan10 merged commit ca135a6 into sodafoundation:master Nov 28, 2022

anvithks reviewed Nov 29, 2022

View reviewed changes

anvithks mentioned this pull request Nov 29, 2022

Confirm with user before deleting existing Go installation. #1364

Open

added ansible installer for multicloud #1359

added ansible installer for multicloud #1359

Conversation

devanshjain7 commented Nov 21, 2022 • edited

codecov bot commented Nov 24, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PravinRanjan10 left a comment

Choose a reason for hiding this comment

joseph-v left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devanshjain7 commented Nov 21, 2022 •

edited

codecov bot commented Nov 24, 2022 •

edited