-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean data type still not working, improve test #270
Comments
@vankesteren I'm trying to reproduce the issue, but I get the correct results. Which version of polars are you on? |
Alright nice that was it. I was on 0.19.3 I think, moving to >0.20 fixed things. Should we update our minimum version in our dependencies? |
Sure, let's just put the minimum at the current version. |
This was referenced Mar 6, 2024
Merged
qubixes
pushed a commit
that referenced
this issue
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #260 we thought boolean data types were now fully supported. However, this is not yet the case due to some weird datatype issues when running
pl.Series(values: list[numpy.bool_])
. This should be fixed and we should build an integration test with a debug dataset with many different data types. The debug dataset should be added to the demo datasets already built into our package.reprex:
Results in the following data types:
However, when we fit and synthesize a model:
We get the wrong data types:
Even though the model seems to be correct:
We should also be careful in serialization to json. I'm not sure whether this works correctly now and should be part of our integration test too.
The text was updated successfully, but these errors were encountered: