Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move types to be first entry in package.json exports #227

Merged
merged 1 commit into from
Jan 6, 2023
Merged

fix: move types to be first entry in package.json exports #227

merged 1 commit into from
Jan 6, 2023

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jan 5, 2023

"types" - can be used by typing systems to resolve the typing file for the given export. This condition should always be included first.

https://nodejs.org/api/packages.html#community-conditions-definitions

https://publint.dev/radash@10.3.2

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
radash-docs ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 11:02PM (UTC)

Copy link
Owner

@sodiray sodiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dsherret thank you for the PR 🍻 this is an odd requirement I didn't know about so thank you for sharing and fixing it.

@sodiray sodiray merged commit 618cae2 into sodiray:master Jan 6, 2023
@sodiray
Copy link
Owner

sodiray commented Jan 6, 2023

Just FYI, this won't be released until the next release PR is pushed through. Not sure when that will be. If this is something you need now or you think it's pressing I can do a version only release to get the package.json out in a v10.4.1 release.

@dsherret
Copy link
Contributor Author

dsherret commented Jan 6, 2023

That’s ok. I don’t need it, but thank you. I am just working on this bug: denoland/deno#17279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants