Feat (number) / inRange function #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I don't know if we want equivalent of inRange. Lodash inRange is extremely funky. The most minor is that the 2nd value is exclusive. And they have variadic behavior which is confusing. Maybe to simplify, both start and end should be inclusive by default, with option to make it exclusive. And maybe we can remove the variadic behavior and it should always take 4 values: |
mertdy
force-pushed
the
feat/in-range-function
branch
from
d16df86
to
42bdc45
Compare
|
Hey @rayepps, I added overloading functions. If you have time to review, we can proceed the PR. |
|
Thank you @mertdy finally merged it 🙃 🎉 will go out in next release of v12.0.0 (likely today) |
aleclarson
referenced
this pull request
in radashi-org/radashi
Jun 24, 2024
* Add inRange function * Match with lodash inRange function * Build cdn * Add overloading functions * Build cdn --------- Co-authored-by: Ray Epps <ray@unishine.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The equivalent of lodash's inRange function. lodash.inRange
Checklist
package.jsonhas been bumped (matching semver)yarn buildcommand has been run and to update thecdndirectory/docsdirectory) has been updatedResolves
None. It is a new feature.