-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (number) / inRange function #255
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I don't know if we want equivalent of inRange. Lodash inRange is extremely funky. The most minor is that the 2nd value is exclusive. And they have variadic behavior which is confusing. Maybe to simplify, both start and end should be inclusive by default, with option to make it exclusive. And maybe we can remove the variadic behavior and it should always take 4 values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mertdy sorry for the very long delay here. I love this PR, I love the docs, the build, the format. You're making it easy on me.
I just had one small comment. If you're still interested in getting this in we can release asap.
d16df86
to
42bdc45
Compare
Hey @rayepps, I added overloading functions. If you have time to review, we can proceed the PR. |
Thank you @mertdy finally merged it 🙃 🎉 will go out in next release of v12.0.0 (likely today) |
* Add inRange function * Match with lodash inRange function * Build cdn * Add overloading functions * Build cdn --------- Co-authored-by: Ray Epps <ray@unishine.dev>
Description
The equivalent of lodash's inRange function. lodash.inRange
Checklist
package.json
has been bumped (matching semver)yarn build
command has been run and to update thecdn
directory/docs
directory) has been updatedResolves
None. It is a new feature.