Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in Array.isArray for isArray #285

Merged

Conversation

gquittet
Copy link
Contributor

@gquittet gquittet commented Apr 6, 2023

Description

The isArray is already implemented in JavaScript / Node.js.

I think we should use the Array.isArray function

And Array.isArray is slightly speedier than the custom one written in radash.

image

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 3:43pm

@sodiray
Copy link
Owner

sodiray commented Jun 26, 2023

Thanks for the PR @gquittet 🙏 I'm going to merge it and publish it in v11.0.0

Would you be willing to share the code/project/setup you used to do the perf tests? I've been thinking of adding a suite to ensure changes don't cause performance regressions but I have little (no) exp with it.

@sodiray sodiray merged commit ef1a730 into sodiray:master Jun 26, 2023
7 of 8 checks passed
@gquittet
Copy link
Contributor Author

gquittet commented Jun 26, 2023

Hello @rayepps 👋

I'm using benchmarkify
but unfortunately it's not maintained anymore since 2 years.

I can look for a solid and maintained solution that is compatible with GitHub Actions.
I'm also developing a NodeJS library so, I'm interested with this aspect of performance analysis using CI.

I keep you in touch when I find a great solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants