Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: improve types on min/max functions #310

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

sodiray
Copy link
Owner

@sodiray sodiray commented Jun 26, 2023

Description

Allows for better typing in min/max function so client can easily pass array of number or objects.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #191

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 0:44am

@sodiray sodiray merged commit 6f2a16e into master Jun 27, 2023
7 of 8 checks passed
@sodiray sodiray deleted the fix/min-max-typing branch June 27, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make min function require a getter if the first argument is an array of objects
1 participant