Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add overload for static array in all func #314

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

sodiray
Copy link
Owner

@sodiray sodiray commented Jun 27, 2023

Description

When calling all with a static array of promises the return type was a union of the types which was very unhelpful. Added an overload that specifically handles the types for a statically typed array.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

n/a

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 4:38pm

@sodiray sodiray merged commit 03dd315 into master Jun 27, 2023
8 checks passed
@sodiray sodiray deleted the fix/all-typing branch June 29, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant