Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: type safer implementation for sum function (#358) #359

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jukanntenn
Copy link
Contributor

Description

Type safer implementation for sum function using function overload.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #358

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 1:05am

@sodiray sodiray merged commit 94d43e7 into sodiray:master Feb 21, 2024
7 checks passed
@sodiray
Copy link
Owner

sodiray commented Feb 21, 2024

Thank you for the PR @jukanntenn 🙏 this is a great improvement

aleclarson referenced this pull request in radashi-org/radashi Jun 24, 2024
* types: type safer implementation for `sum` (#358)

* fix checks

---------

Co-authored-by: jukanntenn <jukanntenn@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type safer implementation for sum function
2 participants