Split library into modules #20
Conversation
crypto_stream.js
Outdated
| exports.crypto_stream = function (out, nonce, key) { | ||
| out.fill(0) | ||
| exports.crypto_stream_xor(out, out, nonce, key) | ||
| exports.crypto_stream = function (c, cpos, clen, nonce, key) { |
|
Looks great! Now we have them split we can start cleaning up. Stuff like |
|
@emilbayes we have ensure endianess also yes? |
|
Oh yeah, let's make issues |
|
depends on #21
|
|
I think we should just fail on BE for now, globally |
crypto_verify.js
Outdated
| } | ||
|
|
||
| function sodium_memcmp (a, b) { | ||
| assert(a.byteLength = b.byteLength, 'buffers must be the same size') |
There was a problem hiding this comment.
I am just a casual observer of this PR as I am excited about this! but it looks like the equality comparison is missing another = character here, unless I am missing something
There was a problem hiding this comment.
thanks! fixed in 56416de
crypto_aead.js
Outdated
| function write64LE (buf, int) { | ||
| buf.fill(0, 0, 8) | ||
| buf.writeUInt32LE(int & 0xffffffff) | ||
| buf.writeUInt32LE((int >> 32) & 0xffffffff) |
crypto_box.js
Outdated
|
|
||
| const hash = Buffer.alloc(64) | ||
| crypto_hash_sha512(hash, seed, 32) | ||
| hash.copy(sk, 0, 0, 32) |
There was a problem hiding this comment.
use .set to copy sk.set(hash, ) with typedarrays
|
|
||
| function crypto_sign_seed_keypair (pk, sk, seed) { | ||
| check(seed, crypto_sign_SEEDBYTES) | ||
| seed.copy(sk) |
crypto_aead.js
Outdated
|
|
||
| var ret = -1 | ||
|
|
||
| if (c.length >= crypto_aead_chacha20poly1305_ietf_ABYTES) { |
There was a problem hiding this comment.
You can return early here instead of a nested conditional perhaps?
crypto_aead.js
Outdated
| crypto_stream_chacha20_ietf_xor_ic(m, c, npub, 1, k) | ||
| return 0 |
No description provided.