Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ristretto255 #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lukeburns
Copy link
Contributor

Haven't gotten around to tests yet, and this is currently using ristretto255 as a dependency, which may or may not be desired, but wanted to open for discussion and invite others to contribute.

@chm-diederichs
Copy link
Collaborator

Nice work so far!

Having ristretto255 as a dependency probably isn't a solution, since that is built on TweetNaCl.js and we should avoid depending on another libsodium port.

So for the time being, maybe you could make the work here into a standalone sodium-ristretto module that can be used alongside this library. Meanwhile, we can look into a standalone implementation suitable for this library.

@lukeburns
Copy link
Contributor Author

They're just pulling in the low level utils used as TweetNaCl, the same as sodium-javascript. Sodium-javascript just hard coded directly (looks like internals are a direct copy paste from TweetNaCl). Might be worth abstracting out a standalone library for this that sodium-javascript and ristretto255 can use (this would reduce the size of their library). Alternatively, we could reimplement ristretto255, but this seems a bit wasteful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants