This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
update gitignore file #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
|
I feel like editor-specific ignore patterns belong in Not a very strong objection though, but if you want to do it this way, why not leave the other editor ignore patterns already there? |
|
Yea you are right I will add them back (probably with a little structure to them) |
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
psivesely
approved these changes
May 15, 2018
|
bors: r+ |
|
er..... bors: try |
|
Did I break bors? bors: ping |
|
pong |
|
bors: r+ |
|
ok someone else have a look at this... If everything seems in order perhaps we can just |
|
bors: r+ |
|
bors: r+ |
|
bors is apparently crashing...
This needs to be reported to bors team |
|
bots: r+ |
|
There is some issue with bors, so merging this without it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.