This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
Unpin libc dependency #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kpcyrd would you please point why is it important to merge |
|
Will explain the use case / problem of this when I get to office. Thanks |
|
I would also like to see this merged before we cook the release.
…On Wed, 27 Feb 2019 at 07:27, Dylan DPC ***@***.***> wrote:
Will explain the use case / problem of this when I get to office. Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#317 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPVBViabF7uC6XwhoAFROkqesWW2vHqks5vRiVmgaJpZM4bTtRl>
.
|
|
@dnaq why? |
|
To avoid users of the new release linking in multiple versions of libc when
using sodiumoxide. And also to avoid the issues with unresolvable
dependency conflicts. As soon as the library is on crates.io it will be the
version that people use, so dependency conflicts will generate bug reports.
…On Wed, 27 Feb 2019 at 09:11, Roman ***@***.***> wrote:
@dnaq <https://github.com/dnaq> why?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#317 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPVBU8TzL4o_HqYZ8pG7JSYnSNrEPGpks5vRj2VgaJpZM4bTtRl>
.
|
|
Yes that's right we need to avoid users having conflicts with libc. But at the same time, libc often breaks in point releases, so it also makes sense to pin to a particular version. I will speak to the co-maintainers of libc and get back on this later today or tomorrow. |
|
Okay, i'm fine with this change. |
|
Had a discussion with libc maintainers, they are moving towards making libc semver-compatible. So we are good. in case there are any breaking changes, we need to issue patch releases that pin in to a version where we are fine with libc and report it upstream. |
Dylan-DPC-zz
suggested changes
Feb 27, 2019
Dylan-DPC-zz
previously approved these changes
Feb 27, 2019
Dylan-DPC-zz
approved these changes
Feb 27, 2019
kpp
approved these changes
Feb 27, 2019
|
bors: r+ |
Build failed |
|
bors: r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure we don't run into unresolvable dependency conflicts if any crate depends on
libc = "> 0.2.48".