Skip to content
This repository has been archived by the owner on Sep 4, 2022. It is now read-only.

Update CHANGELOG #322

Merged
merged 3 commits into from Apr 13, 2019
Merged

Update CHANGELOG #322

merged 3 commits into from Apr 13, 2019

Conversation

kpp
Copy link
Member

@kpp kpp commented Mar 17, 2019

No description provided.

@Dylan-DPC-zz
Copy link
Member

Since we are doing this :

  1. i'd prefer if we can have separate sections of the changelog with what changes are added, modified and removed (or deprecated). Maybe a separate section for any dependency change or other version changes.
  2. We don't need to mention all the changes. Some of them are internal and can be omitted from the changelog (such as "happy clippy" and "added CONTRIBUTING.md"

@coveralls
Copy link

coveralls commented Mar 17, 2019 •
edited

Pull Request Test Coverage Report for Build 927

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.472%
Totals Coverage Status
Change from base Build 925: 0.0%
Covered Lines: 2905
Relevant Lines: 3075
💛 - Coveralls

@kpp
Copy link
Member Author

kpp commented Mar 17, 2019

  1. Maybe
  2. I agree, but we'd better track everything to form a nice changelog right before cutting a release.

Dylan-DPC-zz
Dylan-DPC-zz previously approved these changes Mar 28, 2019
View reviewed changes
@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Mar 28, 2019
@bors @kpp
Merge #322
c169830 
322: Fix markdown list for 0.2.0 release in CHANGELOG  r=Dylan-DPC a=kpp



Co-authored-by: Roman Proskuryakov <humbug@deeptown.org>
@bors
Copy link
Contributor

bors bot commented Mar 28, 2019

Build failed

@kpp kpp changed the title Fix markdown list for 0.2.0 release in CHANGELOG Update CHANGELOG Apr 11, 2019
@kpp kpp requested a review from Dylan-DPC-zz April 11, 2019 17:58
@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Apr 13, 2019
@bors @kpp
Merge #322
2a9a743 
322: Update CHANGELOG  r=Dylan-DPC a=kpp



Co-authored-by: Roman Proskuryakov <humbug@deeptown.org>
@bors
Copy link
Contributor

bors bot commented Apr 13, 2019

Build succeeded

@bors bors bot merged commit 503db89 into master Apr 13, 2019
@kpp kpp deleted the changelog branch April 13, 2019 11:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kpp @Dylan-DPC-zz @coveralls