This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
Include libsodium .a .lib #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpp
commented
Apr 27, 2019
Closed
Dylan-DPC-zz
approved these changes
Apr 27, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Apr 27, 2019
332: Include libsodium .a .lib r=Dylan-DPC a=kpp Include raw .a .lib to link them in msvc and mingw As discussed in https://github.com/sodiumoxide/sodiumoxide/issues/326#issuecomment-487273389 Additional crate size = 1,63+2,39+1,75+2,04+1,82+0,565+0,462 = 10,657Mb Co-authored-by: Roman Proskuryakov <humbug@deeptown.org>
This was referenced Apr 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include raw .a .lib to link them in msvc and mingw
As discussed in https://github.com/sodiumoxide/sodiumoxide/issues/326#issuecomment-487273389
Additional crate size = 1,63+2,39+1,75+2,04+1,82+0,565+0,462 = 10,657Mb