This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
Strip vcpkg support and bump version numbers for release #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1362
💛 - Coveralls |
|
Hm. The idea of this CI test was to try to link with vcpkg libsodium. |
dnaq
changed the title
|
I would expect this PR to be clean (only to remove vcpkg support). |
|
This pr won't be merged. I just wanted a branch to push to to run tests.
…On Wed, 22 Jul 2020 at 19:28, Roman Proskuryakov ***@***.***> wrote:
I would expect this PR to be clean (only to remove vcpkg support).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#429 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ5KBJQFADY466DAZ3P6VDR44OS3ANCNFSM4PEPG5ZA>
.
|
vcpkg was undertested, and since we couldn't be sure that the functionality actually works we remove it for now. If support for vcpkg is needed in the future we welcome a pull-request containing support for it together with a good CI-setup.
|
@tasn: pushed the changes. |
|
Closing since #425 is going to get merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.