Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to configure which properties/fields should be taken into account #94

Conversation

rizi
Copy link

@rizi rizi commented May 29, 2024

This is a first draft to fix this issue: soenneker/soenneker.utils.autobogus#175.

It adds the possibility to configure which properties/fields should be taken into account.

@soenneker what do you think about it, any feedback is highly appreciated.

Br

@soenneker
Copy link
Owner

soenneker commented May 31, 2024

@rizi Thank you for putting this together.

Could you check this commit out: 2e5e09a

A few ideas you had in here (like splitting up fields/properties binding flags) I put in that commit.

I wanted to keep the options as an instance because I wanted the ability to have multiple ReflectionCache instances with different options.

It will get published to NuGet and then auto imported into AutoBogus. The options just need exposing in AutoBogus, and then we'll have your problem addressed!

@soenneker soenneker closed this May 31, 2024
@rizi
Copy link
Author

rizi commented May 31, 2024

@rizi Thank you for putting this together.

Could you check this commit out: 2e5e09a

A few ideas you had in here (like splitting up fields/properties binding flags) I put in that commit.

I wanted to keep the options as an instance because I wanted the ability to have multiple ReflectionCache instances with different options.

It will get published to NuGet and then auto imported into AutoBogus. The options just need exposing in AutoBogus, and then we'll have your problem addressed!

@soenneker
Thank you very much!
I will open another PR for exposing an option in AutoBogus.

Br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants