Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RodSectionMaterial classes to be used in WireRestShape #114

Merged
merged 16 commits into from Oct 20, 2023

Conversation

epernod
Copy link
Collaborator

@epernod epernod commented Oct 19, 2023

Split PR #65 into several to solve the problem of divergence in the regression tests.

In this PR we only add the new classes without using it in the WireRestShape:

Add new set of classes which hold the mechanical property and the topology (visual and collision) description of a section of the Rod/Wire.

  • BaseRodSectionMaterial // base class, not a component
  • RodMeshSection // section defined by a mesh
  • RodSpireSection // section defining a spire
  • RodStraightSection // section defining a straight line

@epernod epernod added pr: new feature pr: status to review To notify reviewers to review this pull-request labels Oct 19, 2023
@epernod epernod changed the title Rod sections Add RodSectionMaterial classes to be used in WireRestShape Oct 19, 2023
@epernod epernod requested a review from fredroy October 19, 2023 21:07
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 20, 2023
@fredroy fredroy merged commit fc6a7df into sofa-framework:master Oct 20, 2023
3 of 4 checks passed
@epernod epernod deleted the rodSections branch December 11, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants