Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean namespace, ifdef macro and template instanciations #21

Merged
merged 5 commits into from Jul 18, 2022
Merged

Clean namespace, ifdef macro and template instanciations #21

merged 5 commits into from Jul 18, 2022

Conversation

epernod
Copy link
Collaborator

@epernod epernod commented Jul 11, 2022 •
edited

  • Replace #ifdef and #define by pragma once
  • Update all namespace for a concatenate version
  • Add template instantiation in headers

this PR includes the PR #20 and need to be rebased first.

@epernod epernod marked this pull request as draft July 12, 2022 08:58
@epernod epernod marked this pull request as ready for review July 17, 2022 22:41
@fredroy fredroy merged commit 0d23b6a into sofa-framework:master Jul 18, 2022
@epernod epernod deleted the cleaning branch July 18, 2022 07:11
@epernod epernod mentioned this pull request Jul 18, 2022
Merged
@epernod epernod added the enhancement New feature or request label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@epernod @fredroy