[Component] Factorize interpolation parameters computation between stiffness and mass computation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iffness and mass computation
…iffness and mass computation
hugtalbot
added
the
pr: status to review
# Conflicts: # src/BeamAdapter/component/forcefield/AdaptiveBeamForceFieldAndMass.h # src/BeamAdapter/component/forcefield/AdaptiveBeamForceFieldAndMass.inl
hugtalbot
approved these changes
Aug 12, 2022
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values:
were computed per beam twice, in method computeMass and computeStiffness which are both called in AddForce step.
now compute the values and store them inside BeamLocalMatrices structure (one per beam)
Some small optimization as well in the code to use noInit and factorize some small computation