Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WireRestShape] Remove unnecessary use of Edge2QuatTopologyMapping #64

Merged
merged 2 commits into from Oct 11, 2022

Conversation

epernod
Copy link
Collaborator

@epernod epernod commented Oct 4, 2022

The pointer to the Edge2QuatTopologyMapping mapping is not necessary to manually propagate the topological changes.
The propagation will be done automatically through topology changes pipeline.

…opagate topology change. It will be done automatically through topology changes pipeline
…opagate topology change. It will be done automatically through topology changes pipeline
@epernod epernod added pr: clean pr: status to review To notify reviewers to review this pull-request labels Oct 4, 2022
@epernod
Copy link
Collaborator Author

epernod commented Oct 5, 2022

TODO for me: Add a test on the feature: DropTool

@fredroy
Copy link
Contributor

fredroy commented Oct 11, 2022

TODO for me: Add a test on the feature: DropTool

You will add the test in this PR or in an other PR ?

@epernod
Copy link
Collaborator Author

epernod commented Oct 11, 2022

TODO for me: Add a test on the feature: DropTool

You will add the test in this PR or in an other PR ?

In a new PR because the default scenario of BrokenIn2 is not working in master.

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 11, 2022
@fredroy
Copy link
Contributor

fredroy commented Oct 11, 2022

👍

@fredroy fredroy merged commit c803e81 into sofa-framework:master Oct 11, 2022
@epernod epernod deleted the Clean_WRS branch October 11, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants