Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert draw from OpenGL calls to drawTool #78

Merged
merged 1 commit into from Oct 25, 2022

Conversation

alxbilger
Copy link
Collaborator

No description provided.

@alxbilger alxbilger merged commit 1bccb1a into sofa-framework:master Oct 25, 2022
@hugtalbot
Copy link
Contributor

@alxbilger this PR in BeamAdapter makes SOFA compilation fail and makes nightly binary generation fail : https://ci.inria.fr/sofa-ci-dev/job/sofa-custom/5300/CI_CONFIG=ubuntu_gcc,CI_PYTHON3_VERSION=3.8,CI_TYPE=release/console

@hugtalbot
Copy link
Contributor

@hugtalbot
Copy link
Contributor

Fixed here: sofa-framework/sofa@05b485a

@alxbilger
Copy link
Collaborator Author

Ok, so the failing compilation is on SOFA v22.06, not on master. And it is not surprising if it fetches the master branch of BeamAdapter. So, I agree with your commit on the v22.06 branch. It makes sense.
However, I did not know that there are nightly builds on the v22.06 branch. Since there are very few changes on this branch, is it desired?

@hugtalbot
Copy link
Contributor

well .. indeed @alxbilger it is a bit too much but it allows to have fresh binaries every night :)

@alxbilger
Copy link
Collaborator Author

Sure, but it does not comply with the energy sobriety plan ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants