Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD feature to save a screenshot #90

Merged
merged 3 commits into from
Oct 24, 2023
Merged

ADD feature to save a screenshot #90

merged 3 commits into from
Oct 24, 2023

Conversation

alxbilger
Copy link
Collaborator

save_screenshot

@alxbilger alxbilger mentioned this pull request Oct 17, 2023
Open
6 tasks
@fredroy
Copy link
Collaborator

fredroy commented Oct 17, 2023 •
edited

I would set a filename by default (e.g scenename and a suffix or something like that)
It can become bothersome otherwise IMO

@alxbilger
Copy link
Collaborator Author

I would set a filename by default (e.g scenename and a suffix or something like that) I can become bothersome otherwise IMO

I agree, but I was lazy...

@hugtalbot
Copy link
Contributor

the export looks a bit strange to me:
name

moreover, it would be nice to have a screenshot name with : "scenefilename_i.jpg"

@alxbilger
Copy link
Collaborator Author

@hugtalbot thanks for the feedback. My screenshot looks ok...

caduceus

@alxbilger
Copy link
Collaborator Author

png works well, but jpg is like in your image

@alxbilger
Copy link
Collaborator Author

@hugtalbot could you test again?

@fredroy
Copy link
Collaborator

fredroy commented Oct 24, 2023

@hugtalbot could you test again?

I did and it was OK (ubuntu), jpg or png

@alxbilger
Copy link
Collaborator Author

ok let's go then

@alxbilger alxbilger merged commit 3a99785 into sofa-framework:master Oct 24, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alxbilger @fredroy @hugtalbot