[SofaPython3] Meshing and Caching #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 27, 2020 11:43
…aPython3 into MeshingAndCaching
|
Hi @sescaida , Thank you again for this PR, it looks good to me. Small last thing before merging, could you squash your commits into only one with a commit message that indicate what the commit is about (for example, something like Edit: You can look at this link if you never squashed commits together |
added meshing + caching updating example updated example added functionality for cgal fix for geometry path fixes for verbose options, using logging module from P3 exposing missing paramters for cgal mesher Fixing logging Fix compilation with Windows (not/and are not supported) Fix case where the plugin path contains a "src " string Fix compilation with Windows (not/and are not supported) Fix case where the plugin path contains a "src " string
…ugin.SofaPython3 into MeshingAndCaching
…ugin.SofaPython3 into MeshingAndCaching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
here's the PR, ported to this Repo! I included some fixes to match the arguments of CGAL in meshVolumetricFromSurface() and it now uses the module 'logging' to print the info messages. The user can set the visibility of the messages by adding a line 'logging.basicConfig(level=logging.INFO)' in his scene, as shown in the example.
Best