Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binding/Sofa.Core] Update MechanicalObject Target in test #239

Merged

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 8, 2022

To merge in the same time as sofa-framework/sofa#2766

@guparan
Copy link
Collaborator

guparan commented Mar 8, 2022

1 unit test is failing @fredroy

[ RUN      ] SofaPython3/Sofa.all_tests/75_Sofa_Core_BaseObject_test_getTarget
======================================================================
FAIL: test_getTarget (BaseObject.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "BaseObject.py", line 58, in test_getTarget
    self.assertEqual(c.getTarget(), 'Sofa.Component.Container')
AssertionError: 'SofaBaseMechanics' != 'Sofa.Component.Container'
- SofaBaseMechanics
+ Sofa.Component.Container


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (failures=1)
/home/runner/work/SofaPython3/SofaPython3/artifact/bin/Bindings.Sofa.Tests.d/Core/BaseObject.py:0: Failure
Failed
[  FAILED  ] SofaPython3/Sofa.all_tests/75_Sofa_Core_BaseObject_test_getTarget, where GetParam() = /home/runner/work/SofaPython3/SofaPython3/artifact/bin/Bindings.Sofa.Tests.d/Core/BaseObject.py with args {test_getTarget, } (2 ms)

Looks like the test itself should be modified, am I right?

Copy link
Collaborator

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above 👍

Copy link
Collaborator

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this PR aims to fix a future change in SOFA (see sofa-framework/sofa#2766)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants