[SofaPython3] Separates the pre-loaded python modules out of the python (Fix issue #283) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on environment (BUGFIX) The execution of Sofa from a python3 environement is not working anymore because some features need Sofa & SofaRuntime modules to be loaded but the loading is done when initializing only in the embeded python interpreter. To fix this, the PR move the module loading and access into its own singleton that initialize at first use. Fixing that is important for 22.06 release. For the future, refactoring the PythonEnvironment file to split PythonEnvironment in two, to separate what is actually relevant for the PythonEnvironment and what should be part something like PythonEmbededInterpreter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution of SOFA from a python3 environement is not working anymore because
some features need Sofa & SofaRuntime modules to be loaded but the loading is done when
initializing only in the embeded python interpreter.
To fix this, the PR move the module loading and access into its own singleton that initialize at
first use.
Fixing that is important for 22.06 release.
For the future, refactoring the PythonEnvironment file to split PythonEnvironment in two, to separate what is actually relevant for the PythonEnvironment and what
should be part something like PythonEmbededInterpreter.
Fix #283