Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bindings] Fix Vec/Mat template types #63

Merged
merged 2 commits into from Nov 1, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 30, 2020

introduced by SOFA #1515

@jnbrunet
Copy link
Collaborator

Hey @fredroy ,

Thanks for this PR. The CI is failing to build tho:

 bindings/SofaTypes/src/SofaPython3/SofaTypes/Binding_Mat.cpp:174:31: error: no type named 'Size' in namespace 'sofa'
template <sofa::Size R, sofa::Size C> struct MATRIX {

Could it be missing a header somewhere?

@fredroy
Copy link
Contributor Author

fredroy commented Oct 31, 2020

err... Index and Type are located in Sofa/config.h(.in) so I dont think so 👼 (since SOFA PR #1515)

@jnbrunet
Copy link
Collaborator

jnbrunet commented Nov 1, 2020

CI on macos still fail to build, but it isn't related to this PR (wrong SOFA nightly build again...)
CI on linux built correctly

I'll merge this since it is blocking for people following the master branch of SOFA

@jnbrunet jnbrunet merged commit 97f17e9 into sofa-framework:master Nov 1, 2020
@guparan guparan added this to the v20.12 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants