Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile image plugin with full set #15

Closed
wants to merge 1 commit into from
Closed

Compile image plugin with full set #15

wants to merge 1 commit into from

Conversation

alxbilger
Copy link
Contributor

No description provided.

@fredroy
Copy link
Contributor

fredroy commented Oct 20, 2022

I guess you are enabling the full set for fixing the failing image scene right ?
Thing is, full set is quite heavy to compile so i am wondering if it is really relevant to add +Xmin to the compilation instead of just ignoring the scene itself ? (or update it to not need the "special" template)

@alxbilger
Copy link
Contributor Author

Indeed, my first intention was to fix the failing unit test. But I also think that a CI must [in theory] compile everything (in all configurations). But I agree that we have limited ressources. And I did not realize that the compilation of the full set was that heavy. So, let's go fixing the unit test ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants