Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remoteContext concurrency problem when msg batch handler #347

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Apr 27, 2024

fix remoteContext concurrency problem when msg batch handler

Summary by CodeRabbit

  • New Features

    • Added cloning functionality to the RemotingContext, enhancing the handling of concurrent message processing.
  • Enhancements

    • Improved message processing robustness in RpcCommandHandler by using cloned context for each message.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/XS question labels Apr 27, 2024
Copy link

coderabbitai bot commented Apr 27, 2024

Warning

Rate Limit Exceeded

@EvenLjj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 49 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between cc33824 and d75f81d.

Walkthrough

The recent changes enhance the codebase by introducing a clone() method to the RemotingContext class, facilitating the creation of new instances with specific parameters. This improvement extends to the RpcCommandHandler class, where message processing now involves using a cloned context for each message iteration, ensuring distinct contexts for every operation.

Changes

File Path Change Summary
.../com/alipay/remoting/RemotingContext.java Added a clone() method to RemotingContext.
.../com/alipay/remoting/rpc/protocol/RpcCommandHandler.java Modified run() method to utilize ctx.clone() for message processing.
.../com/alipay/remoting/rpc/protocol/RpcCommandHandlerTest.java Added test cases for RpcCommandHandler behavior.

🐰✨
In the code's warren, deep and wide,
A clone arises with a stride.
Each message, a path anew,
With fresh context, we pursue.
Hop, hop, hop, on we go,
Through the code, the changes flow! 🌟
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@EvenLjj EvenLjj force-pushed the fix/remoteContext_concurrency_problem branch 2 times, most recently from de363bf to 6045b84 Compare April 27, 2024 09:23
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EvenLjj EvenLjj closed this Apr 28, 2024
@EvenLjj EvenLjj reopened this Apr 29, 2024
@sofastack-cla sofastack-cla bot added size/L and removed size/XS labels Apr 29, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@EvenLjj EvenLjj force-pushed the fix/remoteContext_concurrency_problem branch from 33643db to d75f81d Compare April 29, 2024 08:14
Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chuailiwu chuailiwu merged commit 909cff5 into sofastack:master Apr 29, 2024
3 checks passed
JoeCqupt pushed a commit to JoeCqupt/sofa-bolt that referenced this pull request Jun 5, 2024
…ck#347)

Co-authored-by: liujianjun.ljj <liujianjun.ljj@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants