Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_SofaTracerConfigurationListener_order #1193

Conversation

crazysaltfish
Copy link
Contributor

fix_SofaTracerConfigurationListener_order

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/XS labels Jun 21, 2023
Copy link
Contributor

@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1193 (a36a286) into master (967252f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1193      +/-   ##
============================================
- Coverage     71.44%   71.41%   -0.03%     
+ Complexity     1820     1817       -3     
============================================
  Files           253      253              
  Lines          7354     7354              
  Branches        931      931              
============================================
- Hits           5254     5252       -2     
+ Misses         1624     1623       -1     
- Partials        476      479       +3     
Impacted Files Coverage Δ
...a/boot/util/ApplicationListenerOrderConstants.java 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@HzjNeverStop HzjNeverStop merged commit ec5a084 into sofastack:master Jun 21, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants